fix: search items ensure unique keys #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@screw-hand is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR complements #500. Thanks to @lainbo for bringing this issue to my attention during testing, giving me the opportunity to further refine the bug fix.
Linked Issues
Closes #500
Solution
Refer to cmdk Item [cmdk-item] [data-disabled?] [data-selected?] documentation.
Based on the cmdk source code, we removed the invalid prop
idfromCommand.Item.Thanks to the development team for their code review.
Test Information
For testing purposes, you can use this feed: https://deer404.com/feed.xml